V4L/DVB (11807): cx88: remove xc5000 reset for Pinnacle 800i
authorDevin Heitmueller <dheitmueller@kernellabs.com>
Fri, 15 May 2009 00:50:36 +0000 (21:50 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Tue, 16 Jun 2009 21:21:08 +0000 (18:21 -0300)
commitb8d91986e60e5e15a5283935a99ef86650744a46
tree089a71921af05d1ca0eb74ee8eb690c153cb66a4
parente80858e88b2c9c20de849c67ac2804218a25aaa3
V4L/DVB (11807): cx88: remove xc5000 reset for Pinnacle 800i

According to the engineer at PCTV Systems, the xc5000 reset pin is supposed
to be on GPIO12.  However, despite three nights of effort, pulling that GPIO
low didn't reset the xc5000.  While pulling MO_SRST_IO low does reset the
xc5000, this also resets in the s5h1409 being reset as well.  This causes
tuning to always fail since the internal state of the s5h1409 does not match
the driver's state.

Given that the only two conditions in which the driver performs a reset is
during firmware load and powering down the chip, I am taking out the reset.
We know that the chip is being reset when the cx88 comes online, and not being
able to do power management for this board is better than not having any
tuning at all.

Problem discovered when implementing proper power management for the xc5000,
which results in calls to the reset callback *after* s5h1409 is initialized.

Cc: Steven Toth <stoth@kernellabs.com>
Cc: Chaogui Zhang <czhang1974@gmail.com>
Signed-off-by: Devin Heitmueller <dheitmueller@kernellabs.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/video/cx88/cx88-cards.c