drm/i915/gt: Onion unwind for scratch page allocation failure
authorChris Wilson <chris@chris-wilson.co.uk>
Mon, 19 Oct 2020 08:34:44 +0000 (09:34 +0100)
committerRodrigo Vivi <rodrigo.vivi@intel.com>
Wed, 21 Oct 2020 12:32:25 +0000 (08:32 -0400)
commitb8cff311a42df4f15d6432583573d828b5c7b12a
tree0f7ea3b1af036c97bb76ecfcc5d8f31390d08b4e
parent4a9bb58aba6db4eba2a8b3aa1edc415c94a669a8
drm/i915/gt: Onion unwind for scratch page allocation failure

In switching to using objects for our ppGTT scratch pages, care was not
taken to avoid trying to unref NULL objects on failure. And for gen6
ppGTT, it appears we forgot entirely to unwind after a partial allocation
failure.

Fixes: 89351925a477 ("drm/i915/gt: Switch to object allocations for page directories")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Matthew Auld <matthew.auld@intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Reviewed-by: Matthew Auld <matthew.auld@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20201019083444.1286-1-chris@chris-wilson.co.uk
(cherry picked from commit fa812ce96a46efc27cae4dcad866aaee9cb25d28)
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
drivers/gpu/drm/i915/gt/gen6_ppgtt.c
drivers/gpu/drm/i915/gt/gen8_ppgtt.c