panfrost: Defeature 24-bit textures
authorAlyssa Rosenzweig <alyssa@collabora.com>
Tue, 14 Mar 2023 02:15:36 +0000 (22:15 -0400)
committerMarge Bot <emma+marge@anholt.net>
Tue, 14 Mar 2023 23:10:01 +0000 (23:10 +0000)
commitb8b6bb18f5494ec1c5c7d46188a6cafdb7dd6d23
treefe2ded4f5202bd48f16a4f8051ac161acf28fce3
parent7dda731a38251827b38127a71820290450f31d72
panfrost: Defeature 24-bit textures

mesa/st doesn't like to use 24-bit textures, preferring RGBX over true RGB even
for texture views where this isn't valid. Given how silly true RGB is in
practice, I'd rather drop support and fix texture views than go against the
grain and risk more issues down the line since nobody else in tree is testing
these paths and apps really shouldn't be caring.

Fixes page faults in arb_texture_view-rendering-formats_gles3 which tries to
sample an R8G8B8_UINT texture with a R8G8B8X8_UNORM view in one subcase. That
test is now passing reliably.

Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com>
Reviewed-by: Emma Anholt <emma@anholt.net>
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21891>
src/panfrost/ci/panfrost-g52-fails.txt
src/panfrost/lib/pan_format.c