c++: Handle structured bindings like anon unions in initializers [PR108474]
authorJakub Jelinek <jakub@redhat.com>
Tue, 24 Jan 2023 10:28:00 +0000 (11:28 +0100)
committerJakub Jelinek <jakub@redhat.com>
Tue, 24 Jan 2023 10:28:00 +0000 (11:28 +0100)
commitb84e21115700523b4d0ac44275443f7b9c670344
tree224f885eeb0fe0f2a328cf7c77ba8c76d1b0c5bb
parent275820c09e5f397040cbff69c90012dc1e220faf
c++: Handle structured bindings like anon unions in initializers [PR108474]

As reported by Andrew Pinski, structured bindings (with the exception
of the ones using std::tuple_{size,element} and get which are really
standalone variables in addition to the binding one) also use
DECL_VALUE_EXPR and needs the same treatment in static initializers.

On Sun, Jan 22, 2023 at 07:19:07PM -0500, Jason Merrill wrote:
> Though, actually, why not instead fix expand_expr_real_1 (and staticp) to
> look through DECL_VALUE_EXPR?

Doing it when emitting the initializers seems to be too late to me,
we in various spots try to put parts of the static var DECL_INITIAL expressions
into the IL, or e.g. for varpool purposes remember which vars are referenced
there.

This patch moves it to record_reference, which is called from varpool_node::analyze
and so about the same time as gimplification of the bodies which also
replaces DECL_VALUE_EXPRs.

2023-01-24  Jakub Jelinek  <jakub@redhat.com>

PR c++/108474
* cgraphbuild.cc: Include gimplify.h.
(record_reference): Replace VAR_DECLs with DECL_HAS_VALUE_EXPR_P with
their corresponding DECL_VALUE_EXPR expressions after unsharing.

* cp-gimplify.cc (cp_fold_r): Revert 2023-01-19 changes.

* g++.dg/cpp1z/decomp57.C: New test.
* g++.dg/cpp1z/decomp58.C: New test.
gcc/cgraphbuild.cc
gcc/cp/cp-gimplify.cc
gcc/testsuite/g++.dg/cpp1z/decomp57.C [new file with mode: 0644]
gcc/testsuite/g++.dg/cpp1z/decomp58.C [new file with mode: 0644]