drm/amd/powerplay: Fix missing break in switch
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Fri, 25 Jan 2019 21:55:33 +0000 (15:55 -0600)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 15 Feb 2019 07:10:12 +0000 (08:10 +0100)
commitb81afe37ff5598d7bbb5efa5f2ef6997a5d48e5e
tree6317284c9a3f57c376337456001b91b96a96f037
parent56d3178666fb6dbc892665cc3cf4f8074876d687
drm/amd/powerplay: Fix missing break in switch

commit 2f10d823739680d2477ce34437e8a08a53117f40 upstream.

Add missing break statement in order to prevent the code from falling
through to the default case.

The resoning for this is that pclk_vol_table is an automatic variable.
So, it makes no sense to update it just before falling through to the
default case and return -EINVAL.

This bug was found thanks to the ongoing efforts to enabling
-Wimplicit-fallthrough.

Fixes: cd70f3d6e3fa ("drm/amd/powerplay: PP/DAL interface changes for dynamic clock switch")
Cc: stable@vger.kernel.org
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/gpu/drm/amd/powerplay/hwmgr/smu10_hwmgr.c