mISDN: fix possible use-after-free in HFC_cleanup()
authorZou Wei <zou_wei@huawei.com>
Tue, 11 May 2021 06:58:53 +0000 (14:58 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 19 Jul 2021 07:44:38 +0000 (09:44 +0200)
commitb7ee9ae1e0cf55a037c4a99af2acc5d78cb7802d
treecf8cf16ed0ef5af93061973766ea3a55b518c01a
parente759ff76ebbbfcdcf83b6634c54dc47828573d8b
mISDN: fix possible use-after-free in HFC_cleanup()

[ Upstream commit 009fc857c5f6fda81f2f7dd851b2d54193a8e733 ]

This module's remove path calls del_timer(). However, that function
does not wait until the timer handler finishes. This means that the
timer handler may still be running after the driver's remove function
has finished, which would result in a use-after-free.

Fix by calling del_timer_sync(), which makes sure the timer handler
has finished, and unable to re-schedule itself.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zou Wei <zou_wei@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/isdn/hardware/mISDN/hfcpci.c