Revert of Sketch splitting SkPicture into an interface and SkBigPicture. (patchset...
authorreed <reed@chromium.org>
Fri, 8 May 2015 00:30:13 +0000 (17:30 -0700)
committerCommit bot <commit-bot@chromium.org>
Fri, 8 May 2015 00:30:13 +0000 (17:30 -0700)
commitb7ed856fadae52401d3bbcac22cfc3391780ace8
treedfea1030ca7eb63ea58f1e733cf741c89273d4df
parent8b26b99c97473f020df4b9d4ba789e074e06cedd
Revert of Sketch splitting SkPicture into an interface and SkBigPicture. (patchset #22 id:420001 of https://codereview.chromium.org/1112523006/)

Reason for revert:
speculative revert to fix failures in DEPS roll

Original issue's description:
> Sketch splitting SkPicture into an interface and SkBigPicture.
>
> Adds small pictures for drawRect(), drawTextBlob(), and drawPath().
> These cover about 89% of draw calls from Blink SKPs,
> and about 25% of draw calls from our GMs.
>
> SkPicture handles:
>   - serialization and deserialization
>   - unique IDs
>
> Everything else is left to the subclasses:
>   - playback(), cullRect()
>   - hasBitmap(), hasText(), suitableForGPU(), etc.
>   - LayerInfo / AccelData if applicable.
>
> The time to record a 1-op picture improves a good chunk
> (2 mallocs to 1), and the time to record a 0-op picture
> greatly improves (2 mallocs to none):
>
>     picture_overhead_draw:   450ns -> 350ns
>     picture_overhead_nodraw: 300ns -> 90ns
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/c92c129ff85b05a714bd1bf921c02d5e14651f8b

TBR=reed@google.com,robertphillips@google.com,mtklein@google.com,mtklein@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/1130333002
26 files changed:
gyp/core.gypi
gyp/utils.gypi
include/core/SkPicture.h
include/core/SkPictureRecorder.h
include/utils/SkPictureUtils.h
src/core/SkBigPicture.cpp [deleted file]
src/core/SkBigPicture.h [deleted file]
src/core/SkLayerInfo.cpp [new file with mode: 0644]
src/core/SkLayerInfo.h
src/core/SkMiniRecorder.cpp [deleted file]
src/core/SkMiniRecorder.h [deleted file]
src/core/SkPicture.cpp
src/core/SkPictureCommon.h [deleted file]
src/core/SkPictureRecorder.cpp
src/core/SkRecordDraw.cpp
src/core/SkRecordDraw.h
src/core/SkRecorder.cpp
src/core/SkRecorder.h
src/core/SkRecords.h
src/gpu/GrLayerHoister.cpp
src/gpu/GrRecordReplaceDraw.cpp
src/gpu/SkGpuDevice.cpp
src/gpu/SkGpuDevice.h
src/utils/SkPictureUtils.cpp [new file with mode: 0644]
tests/GpuLayerCacheTest.cpp
tests/PictureTest.cpp