AliasSetTracker: UnknownInsts should contribute to the refcount
authorDavid Majnemer <david.majnemer@gmail.com>
Wed, 19 Nov 2014 09:41:05 +0000 (09:41 +0000)
committerDavid Majnemer <david.majnemer@gmail.com>
Wed, 19 Nov 2014 09:41:05 +0000 (09:41 +0000)
commitb7adf34ee064057d21de889445502ae01106f797
treee164d8dc0c26655cb08bf0c253aba064cf46459a
parentec66d00933cd406463266d9cc240f7ed00038606
AliasSetTracker: UnknownInsts should contribute to the refcount

AliasSetTracker::addUnknown may create an AliasSet devoid of pointers
just to contain an instruction if no suitable AliasSet already exists.
It will then AliasSet::addUnknownInst and we will be done.

However, it's possible for addUnknown to choose an existing AliasSet to
addUnknownInst.
If this were to occur, we are in a bit of a pickle: removing pointers
from the AliasSet can cause the entire AliasSet to become destroyed,
taking our unknown instructions out with them.

Instead, keep track whether or not our AliasSet has any unknown
instructions.

This fixes PR21582.

llvm-svn: 222338
llvm/include/llvm/Analysis/AliasSetTracker.h
llvm/lib/Analysis/AliasSetTracker.cpp
llvm/test/Transforms/LICM/PR21582.ll [new file with mode: 0644]