rtpsink: set sync off on rtcp_sink
authorMarc Leeman <m.leeman@televic.com>
Thu, 30 Sep 2021 11:19:40 +0000 (13:19 +0200)
committerGStreamer Marge Bot <gitlab-merge-bot@gstreamer-foundation.org>
Fri, 1 Oct 2021 22:57:02 +0000 (22:57 +0000)
commitb7820a0de74d686724d731433c494b6499a8bc28
treee1000d668b4b930df85bdcaeadd7e2aee2dcb50c
parent7aa88364ac3f07d33450886df82f377c57d0f374
rtpsink: set sync off on rtcp_sink

When using the following setup (the error can be reproduced using
simpler sender pipelines), the receiver resynchronises the clock on RTCP
packets. The effect was that a couple seconds were cut out of the
playback because an initial RTCP packet was dropped.

When sending out all RTCP packets (setting sync=FALSE on the RTCP
updsink), the playback is fine.

This syncs rtpsink with rtpsrc (where this property was already set).

gst-launch-1.0 filesrc location=899-en.mp3 \
    ! mpegaudioparse \
    ! mpg123audiodec \
    ! audioconvert \
    ! audioresample \
    ! avenc_g722 \
    ! rtpg722pay
    ! rtpsink uri=rtp://239.1.2.3:1234

gst-launch-1.0 uridecodebin rtp://239.1.2.3:1234?encoding-name=G722 \
    ! autoaudiosink

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/993>
subprojects/gst-plugins-bad/gst/rtp/gstrtpsink.c