uio: fix a sleep-in-atomic-context bug in uio_dmem_genirq_irqcontrol()
authorJia-Ju Bai <baijiaju1990@gmail.com>
Wed, 18 Dec 2019 09:44:05 +0000 (17:44 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 28 Feb 2020 14:42:20 +0000 (15:42 +0100)
commitb77fa964ecb1d72a671234f5bea95b41f77c233a
treebaf1b448a9a24ddaf4f95b26555a1cfa3735e223
parentf1af15f459b34c0bd39b19afc1ed9855891da771
uio: fix a sleep-in-atomic-context bug in uio_dmem_genirq_irqcontrol()

[ Upstream commit b74351287d4bd90636c3f48bc188c2f53824c2d4 ]

The driver may sleep while holding a spinlock.
The function call path (from bottom to top) in Linux 4.19 is:

kernel/irq/manage.c, 523:
synchronize_irq in disable_irq
drivers/uio/uio_dmem_genirq.c, 140:
disable_irq in uio_dmem_genirq_irqcontrol
drivers/uio/uio_dmem_genirq.c, 134:
_raw_spin_lock_irqsave in uio_dmem_genirq_irqcontrol

synchronize_irq() can sleep at runtime.

To fix this bug, disable_irq() is called without holding the spinlock.

This bug is found by a static analysis tool STCheck written by myself.

Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Link: https://lore.kernel.org/r/20191218094405.6009-1-baijiaju1990@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/uio/uio_dmem_genirq.c