staging: octeon: Fix return type of cvm_oct_xmit and cvm_oct_xmit_pow
authorNathan Huckleberry <nhuck@google.com>
Wed, 14 Sep 2022 21:10:57 +0000 (14:10 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 24 Sep 2022 11:07:31 +0000 (13:07 +0200)
commitb77599043f00fce9253d0f22522c5d5b521555ce
tree7f6bff1119cecc762ac2c31b9c73e626955b830d
parent9fabdbe8bcce08faaa51f618a87e3bf3ac264462
staging: octeon: Fix return type of cvm_oct_xmit and cvm_oct_xmit_pow

The ndo_start_xmit field in net_device_ops is expected to be of type
netdev_tx_t (*ndo_start_xmit)(struct sk_buff *skb, struct net_device *dev).

The mismatched return type breaks forward edge kCFI since the underlying
function definition does not match the function hook definition.

The return type of cvm_oct_xmit and cvm_oct_xmit_pow should be changed
from int to netdev_tx_t.

Link: https://github.com/ClangBuiltLinux/linux/issues/1703
Cc: llvm@lists.linux.dev
Reported-by: Dan Carpenter <error27@gmail.com>
Reviewed-by: Nathan Chancellor <nathan@kernel.org>
Acked-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Nathan Huckleberry <nhuck@google.com>
Link: https://lore.kernel.org/r/20220914211057.423617-1-nhuck@google.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/octeon/ethernet-tx.c
drivers/staging/octeon/ethernet-tx.h