ext4: dont return EINVAL from GETFSUUID when reporting UUID length
authorDarrick J. Wong <djwong@kernel.org>
Thu, 10 Nov 2022 20:16:29 +0000 (12:16 -0800)
committerTheodore Ts'o <tytso@mit.edu>
Fri, 9 Dec 2022 02:49:24 +0000 (21:49 -0500)
commitb76abb5157468756163fe7e3431c9fe32cba57ca
treeaa7af365db6a4810e277ed9fca58acb80021a8cc
parent26d75a16af285a70863ba6a81f85d81e7e65da50
ext4: dont return EINVAL from GETFSUUID when reporting UUID length

If userspace calls this ioctl with fsu_length (the length of the
fsuuid.fsu_uuid array) set to zero, ext4 copies the desired uuid length
out to userspace.  The kernel call returned a result from a valid input,
so the return value here should be zero, not EINVAL.

While we're at it, fix the copy_to_user call to make it clear that we're
only copying out fsu_len.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Catherine Hoang <catherine.hoang@oracle.com>
Link: https://lore.kernel.org/r/166811138914.327006.9241306894437166566.stgit@magnolia
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Cc: stable@kernel.org
fs/ext4/ioctl.c