firewire: sbp2: omit Scsi_Host lock from queuecommand
authorStefan Richter <stefanr@s5r6.in-berlin.de>
Fri, 22 Apr 2011 10:21:44 +0000 (12:21 +0200)
committerStefan Richter <stefanr@s5r6.in-berlin.de>
Tue, 10 May 2011 20:53:45 +0000 (22:53 +0200)
commitb75ca5ea8e439893121ad80406a3c04c4b7612ab
tree9a260ae737d99d66aa3d42fdfb0bda2125ca47e2
parent6ea9e7bbfc389a12d52646449a201fe933ccd663
firewire: sbp2: omit Scsi_Host lock from queuecommand

firewire-sbp2 already takes care for internal serialization where
required (ORB list accesses), and it does not use cmd->serial_number
internally.  Hence it is safe to not grab the shost lock around
queuecommand.

While we are at housekeeping, drop a redundant struct member:
sbp2_command_orb.done is set once in a hot path and dereferenced once in
a hot path.  We can as well dereference sbp2_command_orb.cmd->scsi_done
instead.

Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
drivers/firewire/sbp2.c