ipv6: Fix suspicious RCU usage warning in ip6mr
authorMadhuparna Bhowmik <madhuparnabhowmik10@gmail.com>
Sat, 16 May 2020 07:45:15 +0000 (13:15 +0530)
committerDavid S. Miller <davem@davemloft.net>
Sat, 16 May 2020 20:41:53 +0000 (13:41 -0700)
commitb6dd5acde3f165e364881c36de942c5b252e2a27
tree36bf56fa15943f762cc5ccd338ed26fb7c74e316
parentf85c1598ddfe83f61d0656bd1d2025fa3b148b99
ipv6: Fix suspicious RCU usage warning in ip6mr

This patch fixes the following warning:

=============================
WARNING: suspicious RCU usage
5.7.0-rc4-next-20200507-syzkaller #0 Not tainted
-----------------------------
net/ipv6/ip6mr.c:124 RCU-list traversed in non-reader section!!

ipmr_new_table() returns an existing table, but there is no table at
init. Therefore the condition: either holding rtnl or the list is empty
is used.

Fixes: d1db275dd3f6e ("ipv6: ip6mr: support multiple tables")
Reported-by: kernel test robot <lkp@intel.com>
Suggested-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv6/ip6mr.c