[clang-tidy] Improve google-objc-function-naming diagnostics 📙
authorStephane Moore <mog@google.com>
Fri, 14 Dec 2018 03:13:31 +0000 (03:13 +0000)
committerStephane Moore <mog@google.com>
Fri, 14 Dec 2018 03:13:31 +0000 (03:13 +0000)
commitb69ece899d60c5397a884442733c93fa6cf0824b
treea9fb7b7ece337c58b6db44a9b451e51da7dd0f19
parent918adb56d865df7896d3c5514066ebff476bd612
[clang-tidy] Improve google-objc-function-naming diagnostics ðŸ“™

Summary:
The diagnostics from google-objc-function-naming check will be more
actionable if they provide a brief description of the requirements from
the Google Objective-C style guide. The more descriptive diagnostics may
help clarify that functions in the global namespace must have an
appropriate prefix followed by Pascal case (engineers working previously
with static functions might not immediately understand the different
requirements of static and non-static functions).

Test Notes:
Verified against the clang-tidy tests.

Reviewers: benhamilton, aaron.ballman

Reviewed By: benhamilton

Subscribers: MyDeveloperDay, xazax.hun, cfe-commits

Differential Revision: https://reviews.llvm.org/D55482

llvm-svn: 349123
clang-tools-extra/clang-tidy/google/FunctionNamingCheck.cpp
clang-tools-extra/test/clang-tidy/google-objc-function-naming.m
clang-tools-extra/test/clang-tidy/google-objc-function-naming.mm