Merge memtag instructions with adjacent stack slots.
authorEvgenii Stepanov <eugenis@google.com>
Wed, 25 Sep 2019 00:03:18 +0000 (17:03 -0700)
committerEvgenii Stepanov <eugenis@google.com>
Wed, 8 Jan 2020 19:02:03 +0000 (11:02 -0800)
commitb675a7628ce6a21b1e4a71c079a67badfb8b073d
tree782914626e3d3bceeffe45a783525be95ce0c6b5
parentba181d0063e43fb56938555112ab859f48aee287
Merge memtag instructions with adjacent stack slots.

Summary:
Detect a run of memory tagging instructions for adjacent stack frame slots,
and replace them with a shorter instruction sequence
* replace STG + STG with ST2G
* replace STGloop + STGloop with STGloop

This code needs to run when stack slot offsets are already known, but before
FrameIndex operands in STG instructions are eliminated; that's the
reason for the new hook in PrologueEpilogue.

This change modifies STGloop and STZGloop pseudos to take the size as an
immediate integer operand, and base address as a FI operand when
possible. This is needed to simplify recognizing an STGloop instruction
as operating on a stack slot post-regalloc.

This improves memtag code size by ~0.25%, and it looks like an additional ~0.1%
is possible by rearranging the stack frame such that consecutive STG
instructions reference adjacent slots (patch pending).

Reviewers: pcc, ostannard

Subscribers: hiraditya, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D70286
13 files changed:
llvm/include/llvm/CodeGen/TargetFrameLowering.h
llvm/lib/CodeGen/PrologEpilogInserter.cpp
llvm/lib/Target/AArch64/AArch64ExpandPseudoInsts.cpp
llvm/lib/Target/AArch64/AArch64FrameLowering.cpp
llvm/lib/Target/AArch64/AArch64FrameLowering.h
llvm/lib/Target/AArch64/AArch64InstrInfo.cpp
llvm/lib/Target/AArch64/AArch64InstrInfo.td
llvm/lib/Target/AArch64/AArch64RegisterInfo.cpp
llvm/lib/Target/AArch64/AArch64SelectionDAGInfo.cpp
llvm/test/CodeGen/AArch64/settag-merge.ll [new file with mode: 0644]
llvm/test/CodeGen/AArch64/settag-merge.mir [new file with mode: 0644]
llvm/test/CodeGen/AArch64/settag.ll
llvm/test/CodeGen/AArch64/stack-tagging-unchecked-ld-st.ll