NFS: NFSv2/v3 clients should never be setting NFS_CAP_XATTR
authorTrond Myklebust <trond.myklebust@hammerspace.com>
Tue, 22 Feb 2022 23:20:38 +0000 (18:20 -0500)
committerTrond Myklebust <trond.myklebust@hammerspace.com>
Fri, 25 Feb 2022 23:50:13 +0000 (18:50 -0500)
commitb622ffe1d9ecbac71f0cddb52ff0831efdf8fb83
tree5341169f1c1663a67aab13a53056b7533defe977
parent41e97b7f8a15d15da03ca15e6ff7b9b7ab7f588c
NFS: NFSv2/v3 clients should never be setting NFS_CAP_XATTR

Ensure that we always initialise the 'xattr_support' field in struct
nfs_fsinfo, so that nfs_server_set_fsinfo() doesn't declare our NFSv2/v3
client to be capable of supporting the NFSv4.2 xattr protocol by setting
the NFS_CAP_XATTR capability.

This configuration can cause nfs_do_access() to set access mode bits
that are unsupported by the NFSv3 ACCESS call, which may confuse
spec-compliant servers.

Reported-by: Olga Kornievskaia <kolga@netapp.com>
Fixes: b78ef845c35d ("NFSv4.2: query the server for extended attribute support")
Cc: stable@vger.kernel.org
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
fs/nfs/nfs3xdr.c
fs/nfs/proc.c