projects / platform / upstream / libSkiaSharp.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 428b2a5) | patch
Add tests (and fix!) for known bad ICO files.
authorscroggo <scroggo@google.com>
Mon, 10 Nov 2014 21:12:25 +0000 (13:12 -0800)
committerCommit bot <commit-bot@chromium.org>
Mon, 10 Nov 2014 21:12:25 +0000 (13:12 -0800)
commitb61e206138607423e83ba34d823c6036f394f655
tree643b948ca1751c4268a3a616745995803e45ee58tree | snapshot
parent428b2a5a4f31334864b2834e8668e7498959580acommit | diff
Add tests (and fix!) for known bad ICO files.

We previously saw crashes decoding bad ICO files. Add tests for
known bad files.

While testing, I learned that one of them still crashes. Check for
large offset and size separately to fix the crash.

BUG=skia:2878

Review URL: https://codereview.chromium.org/712123002
gyp/tests.gypi diff | blob | history
resources/invalid_images/sigabort_favicon.ico [new file with mode: 0644] blob
resources/invalid_images/sigsegv_favicon.ico [new file with mode: 0644] blob
resources/invalid_images/sigsegv_favicon_2.ico [new file with mode: 0644] blob
src/images/SkImageDecoder_libico.cpp diff | blob | history
tests/BadIcoTest.cpp [new file with mode: 0644] blob
Domain: Dotnet / API;