Revert "Change SkCanvas to *not* inherit from SkRefCnt"
authorHeather Miller <hcm@google.com>
Thu, 10 Nov 2016 21:25:30 +0000 (21:25 +0000)
committerSkia Commit-Bot <skia-commit-bot@chromium.org>
Thu, 10 Nov 2016 21:25:44 +0000 (21:25 +0000)
commitb613c266df48cf45296ecc23d1bd7098c84bb7ba
tree50f7d84a4238918bf5869ee760ed78332b2db946
parentfac8db2df8b5cf6fd62189315bad0726d8e51f6d
Revert "Change SkCanvas to *not* inherit from SkRefCnt"

This reverts commit 824075071885b6b741c141cbe2134d8345d34589.

Reason for revert: Breaking WebView (chromium:663959)

Original change's description:
> Change SkCanvas to *not* inherit from SkRefCnt
>
> Definitely tricky for classes like SkNWayCanvas, where the caller (today)
> need not pay attention to ownership of the canvases it gave the NWay
> (after this CL, the caller *must* managed ownership)
>
> BUG=skia:
>
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4441
>
> DOCS_PREVIEW= https://skia.org/?cl=4441
>
> Change-Id: Ib1ac07a3cdf0686d78e7aaa4735d45cc90bea081
> Reviewed-on: https://skia-review.googlesource.com/4441
> Commit-Queue: Mike Reed <reed@google.com>
> Reviewed-by: Florin Malita <fmalita@chromium.org>
> Reviewed-by: Robert Phillips <robertphillips@google.com>
>

TBR=djsollen@google.com,mtklein@google.com,halcanary@google.com,robertphillips@google.com,fmalita@chromium.org,fmalita@google.com,reed@google.com,reviews@skia.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Change-Id: I5e3b3e876b7d2c09833cf841801321033b6b968b
Reviewed-on: https://skia-review.googlesource.com/4687
Commit-Queue: Heather Miller <hcm@google.com>
Reviewed-by: Heather Miller <hcm@google.com>
33 files changed:
dm/DMSrcSink.cpp
gm/aaclip.cpp
gn/android_framework_defines.gni
include/core/SkCanvas.h
include/core/SkMultiPictureDraw.h
include/core/SkPictureRecorder.h
include/svg/SkSVGCanvas.h
include/utils/SkCanvasStateUtils.h
include/utils/SkNullCanvas.h
public.bzl
samplecode/SamplePathFuzz.cpp
src/core/SkCanvas.cpp
src/core/SkConfig8888.cpp
src/core/SkMultiPictureDraw.cpp
src/core/SkSpecialSurface.cpp
src/image/SkSurface.cpp
src/image/SkSurface_Base.h
src/pdf/SkPDFDocument.cpp
src/pdf/SkPDFDocument.h
src/svg/SkSVGCanvas.cpp
src/utils/SkCanvasStateUtils.cpp
src/utils/SkLua.cpp
src/utils/SkNWayCanvas.cpp
src/utils/SkNullCanvas.cpp
src/xps/SkDocument_XPS.cpp
tests/CanvasStateHelpers.cpp
tests/CanvasStateTest.cpp
tests/CanvasTest.cpp
tests/PipeTest.cpp
tests/SVGDeviceTest.cpp
tools/lua/lua_pictures.cpp
tools/skiaserve/Request.h
tools/skp_parser.cpp