ALSA: seq: Correct unlock sequence at snd_seq_client_ioctl_unlock()
authorTakashi Iwai <tiwai@suse.de>
Mon, 15 Apr 2019 07:03:01 +0000 (09:03 +0200)
committerTakashi Iwai <tiwai@suse.de>
Mon, 15 Apr 2019 10:04:31 +0000 (12:04 +0200)
commitb5fd12d6c0fc64c2c2b5ae095e63824083d27151
tree647c1b3d5b8f48e06e19ec148105438f3a6790c8
parent46f5710f0b8829882faea735149d86250db5d0e5
ALSA: seq: Correct unlock sequence at snd_seq_client_ioctl_unlock()

The doubly unlock sequence at snd_seq_client_ioctl_unlock() is tricky.
I took a direct unref call since I thought it would avoid
misunderstanding, but rather this seems more confusing.  Let's use
snd_seq_client_unlock() consistently even if they look strange to be
called twice, and add more comments for avoiding reader's confusion.

Fixes: 6b580f523172 ("ALSA: seq: Protect racy pool manipulation from OSS sequencer")
Reviewed-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/core/seq/seq_clientmgr.c