[WinASan] Improve exception reporting accuracy
authorReid Kleckner <rnk@google.com>
Mon, 30 Nov 2020 18:21:14 +0000 (10:21 -0800)
committerReid Kleckner <rnk@google.com>
Tue, 1 Dec 2020 00:39:22 +0000 (16:39 -0800)
commitb5af5787b367198f8b87626431cb3f66fef460c1
tree2326fb8e8bcdac14457608deea49d093d343fe5e
parent87ff156414370043cf149e0c77513c5227b336b1
[WinASan] Improve exception reporting accuracy

Previously, ASan would produce reports like this:
ERROR: AddressSanitizer: breakpoint on unknown address 0x000000000000 (pc 0x7fffdd7c5e86 ...)

This is unhelpful, because the developer may think this is a null
pointer dereference, and not a breakpoint exception on some PC.

The cause was that SignalContext::GetAddress would read the
ExceptionInformation array to retreive an address for any kind of
exception. That data is only available for access violation exceptions.
This changes it to be conditional on the exception type, and to use the
PC otherwise.

I added a variety of tests for common exception types:
- int div zero
- breakpoint
- ud2a / illegal instruction
- SSE misalignment

I also tightened up IsMemoryAccess and GetWriteFlag to check the
ExceptionCode rather than looking at ExceptionInformation[1] directly.

Differential Revision: https://reviews.llvm.org/D92344
compiler-rt/lib/sanitizer_common/sanitizer_win.cpp
compiler-rt/test/asan/TestCases/Windows/breakpoint.cpp [new file with mode: 0644]
compiler-rt/test/asan/TestCases/Windows/illegal_instruction.cpp [new file with mode: 0644]
compiler-rt/test/asan/TestCases/Windows/integer_divide_by_zero.cpp [new file with mode: 0644]
compiler-rt/test/asan/TestCases/Windows/sse_misalignment.cpp [new file with mode: 0644]