netfilter: nf_tables: possible module reference underflow in error path
authorPablo Neira Ayuso <pablo@netfilter.org>
Tue, 9 Aug 2022 15:23:52 +0000 (17:23 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 25 Aug 2022 09:40:21 +0000 (11:40 +0200)
commitb59bee8b05b0e789b5a298cacb09e8aaa3367a29
tree60cf2f4347a3a5c3a39cbaae24bf97e9e7b70152
parent3be4d59808bbd14b022974f9b16152213a5dc4cc
netfilter: nf_tables: possible module reference underflow in error path

commit c485c35ff6783ccd12c160fcac6a0e504e83e0bf upstream.

dst->ops is set on when nft_expr_clone() fails, but module refcount has
not been bumped yet, therefore nft_expr_destroy() leads to module
reference underflow.

Fixes: 8cfd9b0f8515 ("netfilter: nftables: generalize set expressions support")
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/netfilter/nf_tables_api.c