target: Fix virtual LUN=0 target_configure_device failure OOPs
authorNicholas Bellinger <nab@linux-iscsi.org>
Thu, 5 Mar 2015 03:28:24 +0000 (03:28 +0000)
committerSasha Levin <sasha.levin@oracle.com>
Sat, 28 Mar 2015 14:23:05 +0000 (10:23 -0400)
commitb54521a3bfe9970502be05efadda60b4ce6dab07
tree7c825083bc03e4bfb9961e79db4665587942cdfa
parent6526d32f6b0b0bb8fd024580f91a32e2737fae57
target: Fix virtual LUN=0 target_configure_device failure OOPs

[ Upstream commit 5f7da044f8bc1cfb21c962edf34bd5699a76e7ae ]

This patch fixes a NULL pointer dereference triggered by a late
target_configure_device() -> alloc_workqueue() failure that results
in target_free_device() being called with DF_CONFIGURED already set,
which subsequently OOPses in destroy_workqueue() code.

Currently this only happens at modprobe target_core_mod time when
core_dev_setup_virtual_lun0() -> target_configure_device() fails,
and the explicit target_free_device() gets called.

To address this bug originally introduced by commit 0fd97ccf45, go
ahead and move DF_CONFIGURED to end of target_configure_device()
code to handle this special failure case.

Reported-by: Claudio Fleiner <cmf@daterainc.com>
Cc: Claudio Fleiner <cmf@daterainc.com>
Cc: Christoph Hellwig <hch@lst.de>
Cc: <stable@vger.kernel.org> # v3.7+
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
drivers/target/target_core_device.c