Bluetooth: hci_event: Fix using memcmp when comparing keys
authorLuiz Augusto von Dentz <luiz.von.dentz@intel.com>
Thu, 5 Oct 2023 20:59:59 +0000 (13:59 -0700)
committerLuiz Augusto von Dentz <luiz.von.dentz@intel.com>
Sat, 14 Oct 2023 03:00:25 +0000 (20:00 -0700)
commitb541260615f601ae1b5d6d0cc54e790de706303b
tree9d92fd16e9079d287f166de53e96023cc9f7f499
parentc7f59461f5a78994613afc112cdd73688aef9076
Bluetooth: hci_event: Fix using memcmp when comparing keys

memcmp is not consider safe to use with cryptographic secrets:

 'Do  not  use memcmp() to compare security critical data, such as
 cryptographic secrets, because the required CPU time depends on the
 number of equal bytes.'

While usage of memcmp for ZERO_KEY may not be considered a security
critical data, it can lead to more usage of memcmp with pairing keys
which could introduce more security problems.

Fixes: 455c2ff0a558 ("Bluetooth: Fix BR/EDR out-of-band pairing with only initiator data")
Fixes: 33155c4aae52 ("Bluetooth: hci_event: Ignore NULL link key")
Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
net/bluetooth/hci_event.c