PM / devfreq: Fix static checker warning in try_then_request_governor
authorEnric Balletbo i Serra <enric.balletbo@collabora.com>
Wed, 13 Mar 2019 12:22:53 +0000 (13:22 +0100)
committerMyungJoo Ham <myungjoo.ham@samsung.com>
Tue, 16 Apr 2019 00:29:18 +0000 (09:29 +0900)
commitb53b0128052ffd687797d5f4deeb76327e7b5711
tree18949b386205cc8dc96207e9c8b641283a15d10c
parentbc658bef97a70094d4347faab7cabf2f5267d03f
PM / devfreq: Fix static checker warning in try_then_request_governor

The patch 23c7b54ca1cd: "PM / devfreq: Fix devfreq_add_device() when
drivers are built as modules." leads to the following static checker
warning:

    drivers/devfreq/devfreq.c:1043 governor_store()
    warn: 'governor' can also be NULL

The reason is that the try_then_request_governor() function returns both
error pointers and NULL. It should just return error pointers, so fix
this by returning a ERR_PTR to the error intead of returning NULL.

Fixes: 23c7b54ca1cd ("PM / devfreq: Fix devfreq_add_device() when drivers are built as modules.")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>
drivers/devfreq/devfreq.c