mptcp: Do not return EINPROGRESS when subflow creation succeeds
authorMat Martineau <mathew.j.martineau@linux.intel.com>
Mon, 25 Jul 2022 20:52:31 +0000 (13:52 -0700)
committerJakub Kicinski <kuba@kernel.org>
Wed, 27 Jul 2022 02:57:55 +0000 (19:57 -0700)
commitb5177ed92bf6f9d90a2493ed51c1327e088be1df
treeb6e8b4eb8dd35c69e8564c9041c07a9a440df2e3
parente77ea97d2bd99b004e96c339ee22408c5475a52e
mptcp: Do not return EINPROGRESS when subflow creation succeeds

New subflows are created within the kernel using O_NONBLOCK, so
EINPROGRESS is the expected return value from kernel_connect().
__mptcp_subflow_connect() has the correct logic to consider EINPROGRESS
to be a successful case, but it has also used that error code as its
return value.

Before v5.19 this was benign: all the callers ignored the return
value. Starting in v5.19 there is a MPTCP_PM_CMD_SUBFLOW_CREATE generic
netlink command that does use the return value, so the EINPROGRESS gets
propagated to userspace.

Make __mptcp_subflow_connect() always return 0 on success instead.

Fixes: ec3edaa7ca6c ("mptcp: Add handling of outgoing MP_JOIN requests")
Fixes: 702c2f646d42 ("mptcp: netlink: allow userspace-driven subflow establishment")
Acked-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
Link: https://lore.kernel.org/r/20220725205231.87529-1-mathew.j.martineau@linux.intel.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/mptcp/subflow.c