soc: ti: Fix reference imbalance in knav_dma_probe
authorZhang Qilong <zhangqilong3@huawei.com>
Sun, 22 Nov 2020 03:22:37 +0000 (19:22 -0800)
committerSantosh Shilimkar <santosh.shilimkar@oracle.com>
Sun, 22 Nov 2020 03:22:37 +0000 (19:22 -0800)
commitb4fa73358c306d747a2200aec6f7acb97e5750e6
treeffbb898abf73523390f1cf05e05a04b996d4e352
parent8465c7d1001a86e87f03124dc4a35760e731af62
soc: ti: Fix reference imbalance in knav_dma_probe

The patch fix two reference leak.

  1) pm_runtime_get_sync will increment pm usage counter even it
     failed. Forgetting to call put operation will result in
     reference leak.

  2) The pm_runtime_enable will increase power disable depth. Thus
     a pairing decrement is needed on the error handling path to
     keep it balanced.

We fix it by: 1) adding call pm_runtime_put_noidle or
pm_runtime_put_sync in error handling. 2) adding pm_runtime_disable
in error handling, to keep usage counter and disable depth balanced.

Fixes: 88139ed030583 ("soc: ti: add Keystone Navigator DMA support")
Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com>
Signed-off-by: Santosh Shilimkar <santosh.shilimkar@oracle.com>
drivers/soc/ti/knav_dma.c