drm/vc4: hdmi: Switch to drmm_kzalloc
authorMaxime Ripard <maxime@cerno.tech>
Mon, 11 Jul 2022 17:39:07 +0000 (19:39 +0200)
committerMaxime Ripard <maxime@cerno.tech>
Wed, 13 Jul 2022 08:46:09 +0000 (10:46 +0200)
commitb4f2c70c1a7a0a7708c9755a9946452ee23adeb6
treebafb92c98a40272d63db97cfcaa9334e2ede8cca
parent7b44e4de72dcd5a5769ad19c5cc2cc2b28c0a778
drm/vc4: hdmi: Switch to drmm_kzalloc

Our internal structure that stores the DRM entities structure is allocated
through a device-managed kzalloc.

This means that this will eventually be freed whenever the device is
removed. In our case, the most likely source of removal is that the main
device is going to be unbound, and component_unbind_all() is being run.

However, it occurs while the DRM device is still registered, which will
create dangling pointers, eventually resulting in use-after-free.

Switch to a DRM-managed allocation to keep our structure until the DRM
driver doesn't need it anymore.

Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Link: https://lore.kernel.org/r/20220711173939.1132294-38-maxime@cerno.tech
drivers/gpu/drm/vc4/vc4_hdmi.c