batman-adv: Drop immediate batadv_hard_iface free function
authorSven Eckelmann <sven@narfation.org>
Tue, 5 Jan 2016 11:06:25 +0000 (12:06 +0100)
committerAntonio Quartulli <a@unstable.cc>
Sat, 16 Jan 2016 14:49:51 +0000 (22:49 +0800)
commitb4d922cfc9c08318eeb77d53b7633740e6b0efb0
treed5c6717a8a2330c2fce8df47528dfd167f62a69a
parentae3e1e36e3cb6c686a7a2725af20ca86aa46d62a
batman-adv: Drop immediate batadv_hard_iface free function

It is not allowed to free the memory of an object which is part of a list
which is protected by rcu-read-side-critical sections without making sure
that no other context is accessing the object anymore. This usually happens
by removing the references to this object and then waiting until the rcu
grace period is over and no one (allowedly) accesses it anymore.

But the _now functions ignore this completely. They free the object
directly even when a different context still tries to access it. This has
to be avoided and thus these functions must be removed and all functions
have to use batadv_hardif_free_ref.

Fixes: 89652331c00f ("batman-adv: split tq information in neigh_node struct")
Signed-off-by: Sven Eckelmann <sven@narfation.org>
Signed-off-by: Marek Lindner <mareklindner@neomailbox.ch>
Signed-off-by: Antonio Quartulli <a@unstable.cc>
net/batman-adv/hard-interface.h
net/batman-adv/originator.c