sctp: do not retransmit upon FragNeeded if PMTU discovery is disabled
authorMarcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Fri, 5 Jan 2018 13:17:17 +0000 (11:17 -0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 17 Jan 2018 08:45:21 +0000 (09:45 +0100)
commitb4bab9461f89cde8ba11668cbb27a8a79b741416
tree10ec8a2f60f79da9d57077e1cea1ffd3f547f960
parentd48c6464c50ef8e7eac7a04bbd2afcc23f020b21
sctp: do not retransmit upon FragNeeded if PMTU discovery is disabled

[ Upstream commit cc35c3d1edf7a8373a1a5daa80a912dec96a9cd5 ]

Currently, if PMTU discovery is disabled on a given transport, but the
configured value is higher than the actual PMTU, it is likely that we
will get some icmp Frag Needed. The issue is, if PMTU discovery is
disabled, we won't update the information and will issue a
retransmission immediately, which may very well trigger another ICMP,
and another retransmission, leading to a loop.

The fix is to simply not trigger immediate retransmissions if PMTU
discovery is disabled on the given transport.

Changes from v2:
- updated stale comment, noticed by Xin Long

Signed-off-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/sctp/input.c