drm/aspeed: Fix vga_pw sysfs output
authorJoel Stanley <joel@jms.id.au>
Wed, 17 Nov 2021 01:01:45 +0000 (09:01 +0800)
committerMaxime Ripard <maxime@cerno.tech>
Fri, 19 Nov 2021 11:00:14 +0000 (12:00 +0100)
commitb4a6aaeaf4aa79f23775f6688a7e8db3ee1c1303
tree9b21d9657e78c065b77c3bcaeabd2f425e724de3
parent96c5f82ef0a145d3e56e5b26f2bf6dcd2ffeae1c
drm/aspeed: Fix vga_pw sysfs output

Before the drm driver had support for this file there was a driver that
exposed the contents of the vga password register to userspace. It would
present the entire register instead of interpreting it.

The drm implementation chose to mask of the lower bit, without explaining
why. This breaks the existing userspace, which is looking for 0xa8 in
the lower byte.

Change our implementation to expose the entire register.

Fixes: 696029eb36c0 ("drm/aspeed: Add sysfs for output settings")
Reported-by: Oskar Senft <osk@google.com>
Signed-off-by: Joel Stanley <joel@jms.id.au>
Reviewed-by: Jeremy Kerr <jk@codeconstruct.com.au>
Tested-by: Oskar Senft <osk@google.com>
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Link: https://patchwork.freedesktop.org/patch/msgid/20211117010145.297253-1-joel@jms.id.au
drivers/gpu/drm/aspeed/aspeed_gfx_drv.c