[llvm-objcopy] Don't apply --localize flags to common symbols
authorJordan Rupprecht <rupprecht@google.com>
Thu, 1 Nov 2018 17:26:36 +0000 (17:26 +0000)
committerJordan Rupprecht <rupprecht@google.com>
Thu, 1 Nov 2018 17:26:36 +0000 (17:26 +0000)
commitb47475c058b1da5b8ff8aba4e1fd9bb9a9871882
tree46890b206f9704b3b5b8ec53680272418f454ac6
parentab205a31d40eafa0103bddc0abac9e3cfd0041ed
[llvm-objcopy] Don't apply --localize flags to common symbols

Summary:
--localize-symbol and --localize-hidden will currently localize common symbols. GNU objcopy will not localize these symbols even when explicitly requested, which seems reasonable; common symbols should always be global so they can be merged during linking.

See PR39461

Reviewers: jakehehrlich, jhenderson, alexshap, MaskRay, espindola

Reviewed By: jakehehrlich, jhenderson, alexshap, MaskRay

Subscribers: emaste, arichardson, alexshap, MaskRay, llvm-commits

Differential Revision: https://reviews.llvm.org/D53782

llvm-svn: 345856
llvm/test/tools/llvm-objcopy/localize-hidden.test
llvm/test/tools/llvm-objcopy/localize.test
llvm/tools/llvm-objcopy/ELF/ELFObjcopy.cpp
llvm/tools/llvm-objcopy/ELF/Object.cpp
llvm/tools/llvm-objcopy/ELF/Object.h