Don't separate imp/expl def handling for call site params
authorDavid Stenberg <david.stenberg@ericsson.com>
Mon, 27 Jan 2020 10:15:55 +0000 (11:15 +0100)
committerDavid Stenberg <david.stenberg@ericsson.com>
Mon, 27 Jan 2020 10:31:09 +0000 (11:31 +0100)
commitb46baa82fc3ec679cd6192b8ee04960c3e541ed1
tree85f584b249c54137ed5f1929953a5e39b29a48d8
parente77c149f0e4db4e51184f726bd3c5c83b17aa39a
Don't separate imp/expl def handling for call site params

Summary:
Since D70431 the describeLoadedValue() hook takes a parameter register,
meaning that it can now be asked to describe any register. This means
that we can drop the difference between explicit and implicit defines
that we previously had in collectCallSiteParameters().

I have not found any case for any upstream targets where a parameter
register is only implicitly defined, and does not overlap with any
explicit defines. I don't know if such a case would even make sense. So
as far as I have tested, this patch should be a non-functional change.
However, this reduces the complexity of the code a bit, and it will
simplify the implementation of an upcoming patch which solves PR44118.

Reviewers: djtodoro, NikolaPrica, aprantl, vsk

Reviewed By: djtodoro, vsk

Subscribers: hiraditya, llvm-commits

Tags: #debug-info, #llvm

Differential Revision: https://reviews.llvm.org/D73167
llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp