tcp: avoid fragmenting peculiar skbs in SACK
authorYuchung Cheng <ycheng@google.com>
Thu, 11 May 2017 00:01:27 +0000 (17:01 -0700)
committerDavid S. Miller <davem@davemloft.net>
Fri, 12 May 2017 01:35:20 +0000 (21:35 -0400)
commitb451e5d24ba6687c6f0e7319c727a709a1846c06
tree6c608e72316408de39225799630de48ee6d0509c
parentf6ba8d33cfbb46df569972e64dbb5bb7e929bfd9
tcp: avoid fragmenting peculiar skbs in SACK

This patch fixes a bug in splitting an SKB during SACK
processing. Specifically if an skb contains multiple
packets and is only partially sacked in the higher sequences,
tcp_match_sack_to_skb() splits the skb and marks the second fragment
as SACKed.

The current code further attempts rounding up the first fragment
to MSS boundaries. But it misses a boundary condition when the
rounded-up fragment size (pkt_len) is exactly skb size.  Spliting
such an skb is pointless and causses a kernel warning and aborts
the SACK processing. This patch universally checks such over-split
before calling tcp_fragment to prevent these unnecessary warnings.

Fixes: adb92db857ee ("tcp: Make SACK code to split only at mss boundaries")
Signed-off-by: Yuchung Cheng <ycheng@google.com>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: Soheil Hassas Yeganeh <soheil@google.com>
Acked-by: Neal Cardwell <ncardwell@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/tcp_input.c