entry/rcu: Check TIF_RESCHED _after_ delayed RCU wake-up
authorFrederic Weisbecker <frederic@kernel.org>
Wed, 15 Mar 2023 19:43:43 +0000 (19:43 +0000)
committerThomas Gleixner <tglx@linutronix.de>
Tue, 21 Mar 2023 14:13:15 +0000 (15:13 +0100)
commitb416514054810cf2d2cc348ae477cea619b64da7
treedae0069038e7d3306278bcc3b56c1fe754abb75d
parentf87d28673b71b35b248231a2086f9404afbb7f28
entry/rcu: Check TIF_RESCHED _after_ delayed RCU wake-up

RCU sometimes needs to perform a delayed wake up for specific kthreads
handling offloaded callbacks (RCU_NOCB).  These wakeups are performed
by timers and upon entry to idle (also to guest and to user on nohz_full).

However the delayed wake-up on kernel exit is actually performed after
the thread flags are fetched towards the fast path check for work to
do on exit to user. As a result, and if there is no other pending work
to do upon that kernel exit, the current task will resume to userspace
with TIF_RESCHED set and the pending wake up ignored.

Fix this with fetching the thread flags _after_ the delayed RCU-nocb
kthread wake-up.

Fixes: 47b8ff194c1f ("entry: Explicitly flush pending rcuog wakeup before last rescheduling point")
Signed-off-by: Frederic Weisbecker <frederic@kernel.org>
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
Signed-off-by: Joel Fernandes (Google) <joel@joelfernandes.org>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/r/20230315194349.10798-3-joel@joelfernandes.org
kernel/entry/common.c