udp: disable inner UDP checksum offloads in IPsec case
authorAnsis Atteka <aatteka@ovn.org>
Fri, 21 Apr 2017 22:23:05 +0000 (15:23 -0700)
committerDavid S. Miller <davem@davemloft.net>
Mon, 24 Apr 2017 17:48:54 +0000 (13:48 -0400)
commitb40c5f4fde22fb98eff205b3aece05b471c24eed
tree06738e59899f0e8d23aab4f4134dca0f6dd26c0f
parent4d6fa57b4dab0d77f4d8e9d9c73d1e63f6fe8fee
udp: disable inner UDP checksum offloads in IPsec case

Otherwise, UDP checksum offloads could corrupt ESP packets by attempting
to calculate UDP checksum when this inner UDP packet is already protected
by IPsec.

One way to reproduce this bug is to have a VM with virtio_net driver (UFO
set to ON in the guest VM); and then encapsulate all guest's Ethernet
frames in Geneve; and then further encrypt Geneve with IPsec.  In this
case following symptoms are observed:
1. If using ixgbe NIC, then it will complain with following error message:
   ixgbe 0000:01:00.1: partial checksum but l4 proto=32!
2. Receiving IPsec stack will drop all the corrupted ESP packets and
   increase XfrmInStateProtoError counter in /proc/net/xfrm_stat.
3. iperf UDP test from the VM with packet sizes above MTU will not work at
   all.
4. iperf TCP test from the VM will get ridiculously low performance because.

Signed-off-by: Ansis Atteka <aatteka@ovn.org>
Co-authored-by: Steffen Klassert <steffen.klassert@secunet.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/udp_offload.c