Ensure proper locking in QFileInfoGatherer
authorBradley T. Hughes <bradley.hughes@nokia.com>
Wed, 11 Jan 2012 11:47:07 +0000 (12:47 +0100)
committerQt by Nokia <qt-info@nokia.com>
Wed, 11 Jan 2012 23:45:19 +0000 (00:45 +0100)
commitb409a81da5d0d14b3ac96497f60c1b599bac60a7
treedfe6e43c375b3f2163a40b879cc2462b224625ea
parent93a466c6fc3c455dcc9bf1292cc6a2725287a94a
Ensure proper locking in QFileInfoGatherer

The mutex is used to protect the QFileSystemWatcher instance created by
QFileInfoGatherer, except when calling getFileInfos(). Add a locker
before using QFileSystemWatcher in this function.

Note: it appears that QFileInfoGatherer is misusing QFileSystemWatcher
by calling it from multiple threads. QFileSystemWatcher is an event
driven class, and as such, not thread-safe. So far, no problems have
been reported related to this, so I've left the code as-is.

Change-Id: Ib1429d9399e37120acf8e8d3b989b83c4ce24203
Reviewed-by: João Abecasis <joao.abecasis@nokia.com>
src/widgets/dialogs/qfileinfogatherer.cpp