ideapad_laptop: Introduce the use of the managed version of kzalloc
authorHimangi Saraogi <himangi774@gmail.com>
Mon, 9 Jun 2014 21:46:50 +0000 (17:46 -0400)
committerMatthew Garrett <matthew.garrett@nebula.com>
Tue, 10 Jun 2014 23:11:09 +0000 (19:11 -0400)
commitb3facd7ba822ede3e98108e17a75f2c9c3e463af
treeac722323411e57e839d48ccf6e0700a0131d2306
parentb02fdfcc40d74e64d3ea2a2120c96979e1b33128
ideapad_laptop: Introduce the use of the managed version of kzalloc

This patch moves data allocated using kzalloc to managed data allocated
using devm_kzalloc and cleans now unnecessary kfrees in probe and remove
functions. The label sysfs_failed is removed as it is no longer
required.  Also, linux/device.h is added to make sure the devm_*()
routine declarations are unambiguously available.

The following Coccinelle semantic patch was used for making the change:

@platform@
identifier p, probefn, removefn;
@@
struct platform_driver p = {
  .probe = probefn,
  .remove = removefn,
};

@prb@
identifier platform.probefn, pdev;
expression e, e1, e2;
@@
probefn(struct platform_device *pdev, ...) {
  <+...
- e = kzalloc(e1, e2)
+ e = devm_kzalloc(&pdev->dev, e1, e2)
  ...
?-kfree(e);
  ...+>
}

@rem depends on prb@
identifier platform.removefn;
expression e;
@@
removefn(...) {
  <...
- kfree(e);
  ...>
}

Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Matthew Garrett <matthew.garrett@nebula.com>
drivers/platform/x86/ideapad-laptop.c