leds: flash: leds-qcom-flash: Fix an unsigned comparison which can never be negative
authorJiapeng Chong <jiapeng.chong@linux.alibaba.com>
Wed, 31 May 2023 05:35:59 +0000 (13:35 +0800)
committerLee Jones <lee@kernel.org>
Thu, 8 Jun 2023 17:12:46 +0000 (18:12 +0100)
commitb3f4b679ff427bba8208177ea52cc39128995f62
tree1cca474d71f6a58e80f0610e39ca38e1abcf0d3a
parentdda968475beb1939be84c7f34636cbc7bdc0eb14
leds: flash: leds-qcom-flash: Fix an unsigned comparison which can never be negative

The variable 'count' is defined as unsigned type, so the following if
statement is invalid, we can modify the type of count to int.

if (count <= 0) {
dev_err(dev, "No led-sources specified\n");
return -ENODEV;
}

./drivers/leds/flash/leds-qcom-flash.c:546:5-10: WARNING: Unsigned expression compared with zero: count <= 0.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5344
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Signed-off-by: Lee Jones <lee@kernel.org>
Link: https://lore.kernel.org/r/20230531053559.5702-1-jiapeng.chong@linux.alibaba.com
drivers/leds/flash/leds-qcom-flash.c