[C++20] [Modules] Only diagnose the non-inline external variable
authorChuanqi Xu <yedeng.yd@linux.alibaba.com>
Tue, 17 Jan 2023 09:26:48 +0000 (17:26 +0800)
committerChuanqi Xu <yedeng.yd@linux.alibaba.com>
Tue, 17 Jan 2023 09:48:09 +0000 (17:48 +0800)
commitb3eb004ca78f522c91c0d83bafeab2ee753417c8
treec00396b36da23c6fb5f5f8d0e9bf3c14b8ab3686
parent546b710c10fa6cd7eee4bafb80c9cd191f1bd75d
[C++20] [Modules] Only diagnose the non-inline external variable
definitions in header units

Address part of https://github.com/llvm/llvm-project/issues/60079.

Since the the declaration of a non-inline static data member in its
class definition is not a definition. The following form:

```
class A {
public:
    static const int value = 43;
};
```

should be fine to appear in a header unit. From the perspective of
implementation, it looks like we simply forgot to check if the variable
is a definition...

Reviewed By: iains

Differential Revision: https://reviews.llvm.org/D141905
clang/lib/Sema/SemaDecl.cpp
clang/test/CXX/module/module.import/p6.cpp