projects / platform / upstream / nodejs.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: b8ca4ee) | patch
buffer: fix assertion error in WeakCallback
authorFedor Indutny <fedor@indutny.com>
Mon, 12 Oct 2015 20:08:13 +0000 (16:08 -0400)
committerJames M Snell <jasnell@gmail.com>
Tue, 13 Oct 2015 03:57:12 +0000 (20:57 -0700)
commitb3cbd133400a73a54ca8eab5165efe866b26b4c5
tree499bbd141ef768ad248e50eef0b05c135fa46824tree | snapshot
parentb8ca4eecb3ea3b3af2329730e5be71c91e671e5ecommit | diff
buffer: fix assertion error in WeakCallback

`CallbackInfo` is now bound to `ArrayBuffer` instance, not `Uint8Array`,
therefore `SPREAD_ARG` will abort with:

    Assertion failed: ((object)->IsUint8Array())

Make changes necessary to migrate it to `ArrayBuffer`.

See: https://github.com/nodejs/node/pull/3080#issuecomment-147502167

Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/3329
src/node_buffer.cc diff | blob | history
test/addons/buffer-free-callback/binding.cc diff | blob | history
test/addons/buffer-free-callback/test.js diff | blob | history
Domain: Web Framework / Common;