ASoC: kirkwood: Iterate over array indexes instead of using pointer math
authorKees Cook <keescook@chromium.org>
Fri, 27 Jan 2023 22:41:29 +0000 (14:41 -0800)
committerMark Brown <broonie@kernel.org>
Sat, 28 Jan 2023 10:51:05 +0000 (10:51 +0000)
commitb3bcedc0402fcdc5c8624c433562d9d1882749d8
treef26737954248f6c1ae612a0202792263f728da67
parent362e8d0f27c40864b4f8994624409f7b4316d2dd
ASoC: kirkwood: Iterate over array indexes instead of using pointer math

Walking the dram->cs array was seen as accesses beyond the first array
item by the compiler. Instead, use the array index directly. This allows
for run-time bounds checking under CONFIG_UBSAN_BOUNDS as well. Seen
with GCC 13 with -fstrict-flex-arrays:

../sound/soc/kirkwood/kirkwood-dma.c: In function
'kirkwood_dma_conf_mbus_windows.constprop':
../sound/soc/kirkwood/kirkwood-dma.c:90:24: warning: array subscript 0 is outside array bounds of 'const struct mbus_dram_window[0]' [-Warray-bounds=]
   90 |                 if ((cs->base & 0xffff0000) < (dma & 0xffff0000)) {
      |                      ~~^~~~~~

Cc: Liam Girdwood <lgirdwood@gmail.com>
Cc: Mark Brown <broonie@kernel.org>
Cc: Jaroslav Kysela <perex@perex.cz>
Cc: Takashi Iwai <tiwai@suse.com>
Cc: alsa-devel@alsa-project.org
Signed-off-by: Kees Cook <keescook@chromium.org>
Link: https://lore.kernel.org/r/20230127224128.never.410-kees@kernel.org
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/kirkwood/kirkwood-dma.c