pwm: img: Fix null pointer access in probe
authorHauke Mehrtens <hauke@hauke-m.de>
Thu, 20 Aug 2020 17:14:25 +0000 (19:14 +0200)
committerThierry Reding <thierry.reding@gmail.com>
Thu, 24 Sep 2020 07:18:13 +0000 (09:18 +0200)
commitb39c0615d0667b3a6f2f5c4bf99ffadf3b518bb1
tree9d1687967df0543b7087dd6f8964f1052af5beed
parentbce54366946a7a190a1df74f6f605412f731709c
pwm: img: Fix null pointer access in probe

dev_get_drvdata() is called in img_pwm_runtime_resume() before the
driver data is set.
When pm_runtime_enabled() returns false in img_pwm_probe() it calls
img_pwm_runtime_resume() which results in a null pointer access.

This patch fixes the problem by setting the driver data earlier in the
img_pwm_probe() function.

This crash was seen when booting the Imagination Technologies Creator
Ci40 (Marduk) with kernel 5.4 in OpenWrt.

Fixes: e690ae526216 ("pwm: img: Add runtime PM")
Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
Acked-by: Lee Jones <lee.jones@linaro.org>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
drivers/pwm/pwm-img.c