mctp: Remove device type check at unregister
authorMatt Johnston <matt@codeconstruct.com.au>
Thu, 15 Dec 2022 05:49:33 +0000 (13:49 +0800)
committerJakub Kicinski <kuba@kernel.org>
Tue, 20 Dec 2022 01:20:22 +0000 (17:20 -0800)
commitb389a902dd5be4ece505a2e0463b9b034de04bf5
treeb3f5885c49dca51d1339ff11740b6a60e79da8d3
parent62e027fb0e5293d95e8d36655757ef4687c8795d
mctp: Remove device type check at unregister

The unregister check could be incorrectly triggered if a netdev
changes its type after register. That is possible for a tun device
using TUNSETLINK ioctl, resulting in mctp unregister failing
and the netdev unregister waiting forever.

This was encountered by https://github.com/openthread/openthread/issues/8523

Neither check at register or unregister is required. They were added in
an attempt to track down mctp_ptr being set unexpectedly, which should
not happen in normal operation.

Fixes: 7b1871af75f3 ("mctp: Warn if pointer is set for a wrong dev type")
Signed-off-by: Matt Johnston <matt@codeconstruct.com.au>
Link: https://lore.kernel.org/r/20221215054933.2403401-1-matt@codeconstruct.com.au
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/mctp/device.c