[calls] Consistent call protocol for calls.
authorbmeurer <bmeurer@chromium.org>
Wed, 9 Sep 2015 05:01:01 +0000 (22:01 -0700)
committerCommit bot <commit-bot@chromium.org>
Wed, 9 Sep 2015 05:01:22 +0000 (05:01 +0000)
commitb37907ff7f866873ddfbfc97670b43c19a5fc7f9
treeddd8b4ddd38edab55b5ccbde8f2209a50d910045
parentce95a4db6995c824d52098b2ca05b162ee9ff6cc
[calls] Consistent call protocol for calls.

The number of actual arguments should always be available, there's no
point in trying to optimize away a simple assignment of an immediate to
a register before some calls.

The main motivation is to have a consistent state at the beginning of every
function. Currently the arguments register (i.e. rax or eax) either contains
the number of arguments or some random garbage depending on whether
the callsite decided that the callee might need the information or not.
This causes trouble with runtime implementations of functions that
do not set internal_formal_parameter_count to the DontAdaptArguments
sentinel (we don't have any of those yet), but also makes it impossible
to sanity check the arguments in the callee, because the callee doesn't
know whether the caller decided to pass the number of arguments or
random garbage.

BUG=v8:4413
LOG=n

Review URL: https://codereview.chromium.org/1330033002

Cr-Commit-Position: refs/heads/master@{#30648}
16 files changed:
src/arm/lithium-codegen-arm.cc
src/arm/macro-assembler-arm.cc
src/arm64/lithium-codegen-arm64.cc
src/arm64/macro-assembler-arm64.cc
src/hydrogen-instructions.cc
src/hydrogen-instructions.h
src/hydrogen.cc
src/hydrogen.h
src/ia32/lithium-codegen-ia32.cc
src/ia32/macro-assembler-ia32.cc
src/mips/lithium-codegen-mips.cc
src/mips/macro-assembler-mips.cc
src/mips64/lithium-codegen-mips64.cc
src/mips64/macro-assembler-mips64.cc
src/x64/lithium-codegen-x64.cc
src/x64/macro-assembler-x64.cc