tty/serial/amba-pl011: Implement poll_init callback
The callback is used to initialize the hardware, nothing else should be
done, i.e. we should not request interrupts (but we can and do unmask
some of them, as they might be useful for NMI entry).
As a side-effect, the patch also fixes a division by zero[1] when booting
with kgdboc options specified (e.g. kgdboc=ttyAMA0,115200n8). The issue
happens because serial core calls set_termios callback, but the driver
doesn't know clock frequency, and thus cannot calculate proper baud rate
values.
[1]
WARNING: at drivers/tty/serial/serial_core.c:400 uart_get_baud_rate+0xe8/0x14c()
Modules linked in:
[<
c0018e50>] (unwind_backtrace+0x0/0xf0) from [<
c0020ae8>] (warn_slowpath_common+0x4c/0x64)
[<
c0020ae8>] (warn_slowpath_common+0x4c/0x64) from [<
c0020b1c>] (warn_slowpath_null+0x1c/0x24)
[<
c0020b1c>] (warn_slowpath_null+0x1c/0x24) from [<
c0185ed8>] (uart_get_baud_rate+0xe8/0x14c)
[<
c0185ed8>] (uart_get_baud_rate+0xe8/0x14c) from [<
c0187078>] (pl011_set_termios+0x48/0x278)
[<
c0187078>] (pl011_set_termios+0x48/0x278) from [<
c01850b0>] (uart_set_options+0xe8/0x114)
[<
c01850b0>] (uart_set_options+0xe8/0x114) from [<
c0185de4>] (uart_poll_init+0xd4/0xe0)
[<
c0185de4>] (uart_poll_init+0xd4/0xe0) from [<
c016da8c>] (tty_find_polling_driver+0x100/0x17c)
[<
c016da8c>] (tty_find_polling_driver+0x100/0x17c) from [<
c0188538>] (configure_kgdboc+0xc8/0x1b8)
[<
c0188538>] (configure_kgdboc+0xc8/0x1b8) from [<
c00088a4>] (do_one_initcall+0x30/0x168)
[<
c00088a4>] (do_one_initcall+0x30/0x168) from [<
c033784c>] (do_basic_setup+0x94/0xc8)
[<
c033784c>] (do_basic_setup+0x94/0xc8) from [<
c03378e0>] (kernel_init+0x60/0xf4)
[<
c03378e0>] (kernel_init+0x60/0xf4) from [<
c00144a0>] (kernel_thread_exit+0x0/0x8)
---[ end trace
7d41c9186f342c40 ]---
Division by zero in kernel.
[<
c0018e50>] (unwind_backtrace+0x0/0xf0) from [<
c014546c>] (Ldiv0+0x8/0x10)
[<
c014546c>] (Ldiv0+0x8/0x10) from [<
c0187098>] (pl011_set_termios+0x68/0x278)
[<
c0187098>] (pl011_set_termios+0x68/0x278) from [<
c01850b0>] (uart_set_options+0xe8/0x114)
[<
c01850b0>] (uart_set_options+0xe8/0x114) from [<
c0185de4>] (uart_poll_init+0xd4/0xe0)
[<
c0185de4>] (uart_poll_init+0xd4/0xe0) from [<
c016da8c>] (tty_find_polling_driver+0x100/0x17c)
[<
c016da8c>] (tty_find_polling_driver+0x100/0x17c) from [<
c0188538>] (configure_kgdboc+0xc8/0x1b8)
[<
c0188538>] (configure_kgdboc+0xc8/0x1b8) from [<
c00088a4>] (do_one_initcall+0x30/0x168)
[<
c00088a4>] (do_one_initcall+0x30/0x168) from [<
c033784c>] (do_basic_setup+0x94/0xc8)
[<
c033784c>] (do_basic_setup+0x94/0xc8) from [<
c03378e0>] (kernel_init+0x60/0xf4)
[<
c03378e0>] (kernel_init+0x60/0xf4) from [<
c00144a0>] (kernel_thread_exit+0x0/0x8)
Division by zero in kernel.
[<
c0018e50>] (unwind_backtrace+0x0/0xf0) from [<
c014546c>] (Ldiv0+0x8/0x10)
[<
c014546c>] (Ldiv0+0x8/0x10) from [<
c0183a98>] (uart_update_timeout+0x4c/0x5c)
[<
c0183a98>] (uart_update_timeout+0x4c/0x5c) from [<
c01870f8>] (pl011_set_termios+0xc8/0x278)
[<
c01870f8>] (pl011_set_termios+0xc8/0x278) from [<
c01850b0>] (uart_set_options+0xe8/0x114)
[<
c01850b0>] (uart_set_options+0xe8/0x114) from [<
c0185de4>] (uart_poll_init+0xd4/0xe0)
[<
c0185de4>] (uart_poll_init+0xd4/0xe0) from [<
c016da8c>] (tty_find_polling_driver+0x100/0x17c)
[<
c016da8c>] (tty_find_polling_driver+0x100/0x17c) from [<
c0188538>] (configure_kgdboc+0xc8/0x1b8)
[<
c0188538>] (configure_kgdboc+0xc8/0x1b8) from [<
c00088a4>] (do_one_initcall+0x30/0x168)
[<
c00088a4>] (do_one_initcall+0x30/0x168) from [<
c033784c>] (do_basic_setup+0x94/0xc8)
[<
c033784c>] (do_basic_setup+0x94/0xc8) from [<
c03378e0>] (kernel_init+0x60/0xf4)
[<
c03378e0>] (kernel_init+0x60/0xf4) from [<
c00144a0>] (kernel_thread_exit+0x0/0x8)
Signed-off-by: Anton Vorontsov <anton.vorontsov@linaro.org>
Acked-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>