scsi-disk: Move active request asserts
authorStefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Fri, 12 Nov 2010 09:57:11 +0000 (09:57 +0000)
committerKevin Wolf <kwolf@redhat.com>
Wed, 24 Nov 2010 16:30:19 +0000 (17:30 +0100)
commitb30ccdb080bfadfcf447999fe16ba85529b7fc8c
tree75e8079858a8fb5ec6a809fd032a947911583cdc
parentbbfbb6c3df392d170b53b0a519700738fea3570c
scsi-disk: Move active request asserts

SCSI read/write requests should not be re-issued before the current
fragment of I/O completes.  There are asserts in scsi-disk.c that guard
this constraint but they trigger on SPARC Linux 2.4.  It turns out that
the asserts are too early in the code path and don't allow for read
requests to terminate.

Only the read assert needs to be moved but move the write assert too for
consistency.

Reported-by: Nigel Horne <njh@bandsman.co.uk>
Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
hw/scsi-disk.c