Btrfs-progs: check return value of read_tree_block() in check_chunks_and_extents()
authorEryu Guan <guaneryu@gmail.com>
Fri, 10 Jan 2014 14:50:02 +0000 (22:50 +0800)
committerChris Mason <clm@fb.com>
Fri, 31 Jan 2014 16:22:25 +0000 (08:22 -0800)
commitb2e99e1819d967828edf149db5a203e59a40e379
treece30a1c71f736e438a9eaa8ec2cf133cd0850080
parent257a71cb24b04d5a7477b0618665ceb1e1cc149b
Btrfs-progs: check return value of read_tree_block() in check_chunks_and_extents()

The following steps could trigger btrfs segfault:

mkfs -t btrfs -m raid5 -d raid5 /dev/loop{0..3}
losetup -d /dev/loop2
btrfs check /dev/loop0

The reason is that read_tree_block() returns NULL and
add_root_to_pending() dereferences it without checking it first.

Also replace a BUG_ON with proper error checking.

Signed-off-by: Eryu Guan <guaneryu@gmail.com>
Signed-off-by: David Sterba <dsterba@suse.cz>
Signed-off-by: Chris Mason <clm@fb.com>
cmds-check.c
disk-io.c
free-space-cache.c