RDMA: Check for NULL mode in .devnode methods
authorGoldwyn Rodrigues <rgoldwyn@suse.de>
Mon, 4 Jul 2011 16:26:57 +0000 (09:26 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Mon, 4 Jul 2011 22:53:28 +0000 (15:53 -0700)
commitb2bc4782191cb574924a1d09f48083ea8b33a93b
treee91ef7b6fb2869908ce1aa7372747687ad0b5ec3
parentba466c74d99b91b2f390a09ad31bbc6cddd8cf4b
RDMA: Check for NULL mode in .devnode methods

Commits 71c29bd5c235 ("IB/uverbs: Add devnode method to set path/mode")
and c3af0980ce01 ("IB: Add devnode methods to cm_class and umad_class")
added devnode methods that set the mode.

However, these methods don't check for a NULL mode, and so we get a
crash when unloading modules because devtmpfs_delete_node() calls
device_get_devnode() with mode == NULL.

Add the missing checks.

Signed-off-by: Goldwyn Rodrigues <rgoldwyn@suse.de>
[ Also fix cm.c.  - Roland ]
Signed-off-by: Roland Dreier <roland@purestorage.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/infiniband/core/cm.c
drivers/infiniband/core/uverbs_main.c