net: dsa: tag_8021q: fix notifiers broadcast when they shouldn't, and vice versa
authorVladimir Oltean <vladimir.oltean@nxp.com>
Fri, 13 Aug 2021 23:04:22 +0000 (02:04 +0300)
committerDavid S. Miller <davem@davemloft.net>
Mon, 16 Aug 2021 10:14:18 +0000 (11:14 +0100)
commitb2b8913341119491a13d9b11b073dc3c4f907cb8
tree3468baeb2dbe345af63923e1032e754f172c52f3
parent944f510176ebdf6b3a71f7cefea334bd3d203de2
net: dsa: tag_8021q: fix notifiers broadcast when they shouldn't, and vice versa

During the development of the blamed patch, the "bool broadcast"
argument of dsa_port_tag_8021q_vlan_{add,del} was originally called
"bool local", and the meaning was the exact opposite.

Due to a rookie mistake where the patch was modified at the last minute
without retesting, the instances of dsa_port_tag_8021q_vlan_{add,del}
are called with the wrong values. During setup and teardown, cross-chip
notifiers should not be broadcast to all DSA trees, while during
bridging, they should.

Fixes: 724395f4dc95 ("net: dsa: tag_8021q: don't broadcast during setup/teardown")
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/dsa/tag_8021q.c